Remove compegps, cst, g7towin, gopal, gpsman, gpsutil, jogmap, jtr, maggeo, mapsend, nm4, pcx, pocketfms, skyforce, stmsdf, stmwpp, tiger, vpl, vidaone, vitosmt, vitovtt, wfff, and yahoo. (#785)
* Remove compegps, cst, g7to2in, gopal, gpsutil, jtr, maggeo, mapsend,
nm4, pcx, pocketfms, skyforce, stmsdf, stmwpp, tiger, vpl, wfff, and yahoo.
* Missing reference files from above.
* Change classic-3 test to read gzipped NMEA instead of deprecated formats.
* Drop gpsutil from tomtom test as it tested nothing unique.
* Remove gpsman test. It's a unicsv test and this tests nothing of value.
* Eliminate use of gpsutil in gpx test; it covered no unique paths.
* Update other GPSBabel.pro :-(
* Update Cmaeklists enough for successful Mac compile
* Cleanup internal doc references to newly retired formats.
* Scrub (and commit) the remaining doc changes for what we just deleted.
* Squashed commit of the following:
commit
40429dd3db113c30652e8e66b2a38237f1edbf39
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Mon Dec 6 16:37:53 2021 -0700
fix dotnet time conversion (#784)
commit
54b013699f755b9a34f730c9f90729a2961b2704
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Mon Dec 6 07:13:44 2021 -0700
Kill CarteSurTable format. (#783)
Apparently it hasn't ever been used. Our sample has coordinates in UTM,
but we have been interpretting them as degrees/100000. "Le pic du midi"
referred to in the sample is The Pic du Midi de Bigorre.
commit
1ed58953b7a50c9a5e994e3d8d35055bef007fcd
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Sun Dec 5 15:30:05 2021 -0700
harden gbfgetcstr, gbfgetpstr. (#782)
Hangs were detected with afl and the gdb reader and gbfgetcstr. One such
hang reads a fuzzed 32 bit url count with FREAD_i32, and then proceeds
to fetch that many strings with FREAD_CSTR_AS_QSTR. This results in
fetches from beyond EOF that are undetected. gbfgetcstr_old is modified
to throw a fatal error if reading is attempted beyond EOF.
A similar failure was not detected with gbfgetpstr, but it is also
modified to throw a fatal error if reading is attempted beyond EOF.
commit
85502cb3fd168287a24c5b14fa038cc0f02922eb
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Fri Dec 3 07:16:02 2021 -0700
hopefully the real fix for garmin_xt tool issues. (#781)
Fix LGTM detected "Comparison between i of type uint8_t and Count of
wider type int."
This latest find by LGTM is one in a long series of issue detections by
various tools. However, close analysis reveals the previous solutions
to these deteced issues didn't find or fix the real root issues:
commit
233f3c8b0bf69397403b6c1f29af8e10a65a8928, 10/22/2013, Pad
internal buffer to appease -fsanitize=address. While the fix appeased
the sanitizer, it didn't fix the root problem. The root problem was
a bug in the original translation of format_garmin_xt_decrypt_trk_blk
when converting to zero-based array indexing.
commit
dcf0dd85a71c6fa5fc3dac72520c2070ba051108, 7/8/2015, A bunch of
busy work to satisfy hyperactive warnings in newer GCC builds. Again,
the fix didn't fix the root problem. The root problem was a bug in the
original translation of format_garmin_xt_proc_strk. This bug resulted
in a mismatch between our test output and that of the original project.
In our output the timestamp of the last two points in a track was
identical.
This fix results in our output matching the reference file of the original
project (with allowances for precision).
commit
727df5268184fb42a14963002cc77c5c9cf5d692
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Wed Dec 1 17:17:40 2021 -0700
retire cet (#777)
* teach mkshort to split utf8 on grapheme boundaries.
and retire some cet functions.
* add the grapheme test.
* wean gbfile from cet.
* restore cet.cc, cet.h in prepare for deprecation.
* retire cet.cc, cet.h
* drop attempted support of \r line endings in gbfgetutf16str.
* add test of surrogate pairs for gbfgetutf16str.
* fix test
commit
2371d119a57005dd7db23dfcfe576e7608074a67
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Wed Dec 1 13:11:33 2021 -0700
add lgtm configuration file (#780)
commit
16820556e11349523ee7094dc9cd504515070a27
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Wed Dec 1 12:40:38 2021 -0700
move Qt6 CI builds to 6.2.2. (#779)
commit
d377ef65af27e5a0e48d8b4017cc76517e305dfc
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Wed Dec 1 06:26:08 2021 -0700
convert arcdist, polygon, and xcsv to use gpsbabel::TextStream instead of gbfgetstr (#778)
* read style files with a textstream.
* use gpsbabel::textstream instead of gbfile.
commit
f2da18dc2edba69639e51fbe3c7ef8ef161d8eea
Merge:
41cdf06b 23414450
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Tue Nov 30 15:46:26 2021 -0700
Merge pull request #776 from tsteven4/nits3
miscellaneous minor fixes III
commit
41cdf06b34975cbb1b2b1fb848002465803ce280
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Mon Nov 29 07:29:41 2021 -0700
move Qt 5.12 CI builds to 5.12.12 (#774)
commit
2341445085d9f3c3b354c17f9f2527f5de673ee1
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Sun Nov 28 07:44:28 2021 -0700
remove support for non standard entity replacements.
This was disabled in
d47e364f5 August 29, 2005.
commit
dd56f42f5ce0a3ade1ce7b377a1da7a718f037ec
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Sat Nov 27 23:37:59 2021 -0700
fix lgtm detected ill-defined for loop.
commit
59a325d14074bbd9abe32b165b1e10bbb5c69ffa
Merge:
56c86e2b 07694790
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Sat Nov 27 17:45:30 2021 -0700
Merge pull request #772 from tsteven4/lgtm
miscellaneous minor fixes
commit
0769479009f18e10eb131317710ded627db38482
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Fri Nov 26 14:42:42 2021 -0700
sequester temporary style files in TMPDIR
commit
3f38cef6bcede6f58cd4e91fb796e84cc978dd5c
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Thu Nov 25 10:09:04 2021 -0700
prefer rte_waypt_ct() over waypoint_list.count().
this provides some insulation from the underlying WaypointList
container.
commit
bdd7865e7b4ee5ec1b61e94abd9ce63b4eb71aaf
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Thu Nov 25 08:37:57 2021 -0800
sort SOURCES and HEADERS in build.
this gives a reasonable initial project view in Xcode.
this gives a resaonable order to compilation.
commit
dd735b6e8443965d1e5cf47a4b83daf72fa4370c
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Wed Nov 24 11:11:15 2021 -0800
minor correction to resample doc.
commit
f7d3d60b1ac516061c73a05acb4f93b66def95c9
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Wed Nov 24 10:30:58 2021 -0800
further minimize xcsv_get_char_from_constant_table
commit
f483fc350f8aab14a54de7a71374c16f0988f000
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Wed Nov 24 09:51:14 2021 -0800
use list initialization to construct xcsv char map table.
commit
d62f479f0767cd545165ad1fcd1b734fe33eb1c2
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Wed Nov 24 08:52:22 2021 -0800
more nits.
commit
b2957b54db7d208183ab862990c06574a6c088c0
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Tue Nov 23 16:09:14 2021 -0800
limit variable scope, found by LGTM.
Poor global variable name 'ops'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo).
commit
56c86e2bc6ff0413da1057e144a3e899b320f8a8
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Tue Nov 23 09:40:30 2021 -0700
fix parsing of nmea hms fields. (#770)
commit
fa20976bcbedc72cd37100fa40c67a9d299b1b0e
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Sun Nov 21 14:04:55 2021 -0700
Introduce resampling filter and nvectors. (#763)
* Introduce resampling filter and nvectors.
* use ellipsoid model with nvectors.
the code had been forcing a spherical earth model to match the
existing grtcirc.cc calculations.
commit
1a422a68320c6c5449bfee0f28a8da0a65697168
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Sun Nov 21 14:04:03 2021 -0700
improve string handling, fix 9 year old FIXME. (#769)
commit
e09f7fe5996073abf414b3bc2897c8dd84d2429a
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Sun Nov 21 13:34:23 2021 -0700
support generation of xcode project files with qmake. (#760)
commit
ff76e254a269c772da3cf7df94b1cab6b8dab1dc
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Sat Nov 20 08:05:01 2021 -0700
update fit locations test with improved sample (#767)
* update fit test with improved sample.
* reference file mode correction.
commit
67ad13daaaf8d3dee5a1c7643d9c489ef7bc125d
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Fri Nov 19 06:48:53 2021 -0700
Pick up fit locations test case (#766)
* Add support for Locations.fit files
* patch by tsteven4 to address review comments
* Add a test case for Locations.fit files from Garmin devices
Co-authored-by: Fabrizio Gennari <fabrizio.ge@tiscali.it>
commit
368ad391c3a737058dec9fe82e3c33925add9027
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Thu Nov 18 16:40:49 2021 -0700
add test for fit Locations(Lctns) files. (#765)
* add test for fit Locations(Lctns) files.
* fix new bug with change in Qt6 behavior for fit.
commit
871efe320b27bacecd7c98e9f7c0236b83ed9122
Author: fabzzap <fabrizio.ge@tiscali.it>
Date: Thu Nov 18 22:07:59 2021 +0100
Add support for Locations.fit files (#762)
* Add support for Locations.fit files
* patch by tsteven4 to address review comments
commit
2504d97daa490ddb4d0071e219fc4efbff98343a
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Wed Nov 17 08:52:08 2021 -0700
Eliminiate redundant route_head data member (#764)
eliminate redundant route_head data member rte_waypt_ct, replacing it with a member function rte_waypt_ct() that gets the count from the waypoint_list container.
commit
0beebdd5ecd9cadbb0219a5d9682a240a38a2170
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Mon Nov 8 05:22:30 2021 -0700
kill xmap, xmap2006. (#758)
* kill xmap, xmap2006.
* dprecate obsolete readme.
commit
6593293ad8fee54764a9905064d4a647e553cd3f
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Fri Nov 5 15:13:05 2021 -0600
kill xmapwpt. (#757)
note is was wounded previously, see #754.
commit
7b6235ce627e9abac6c7ea34b9560935ad56483d
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Fri Nov 5 13:01:00 2021 -0600
add fedora 35 to CI. (#756)
commit
c3bc9c804ec84292f7a851ddbfba92f3c544e3ac
Author: tsteven4 <
13596209+tsteven4@users.noreply.github.com>
Date: Fri Nov 5 11:17:45 2021 -0600
serial port names (#755)
* try qserialportinfo again.
* update docker images with qt serial port.
* enhance windows device text to match device manager on windows.
* gbfile test can't depend on PCX any longer.\n Might be a hole in coverage.
* Remove vitosmt and vitovtt.
* Remove jogmap vidaone yahoo
* Remove gpsman.
* Remove more crumbs of g7towin.
* Run automated cleanup on the list of files in commit message to clean up last pieces.
* keep gpsutil.h in GPSBabel.pro
Co-authored-by: Robert Lipe <robertlipe@gmail.com>